kconfig: Signal newlib support in Kconfig too #626
Conversation
This lets Kconfig stanzas detect newlib support in the toolchain Signed-off-by: Keith Packard <[email protected]>
galak
left a comment
galak
left a comment
There was a problem hiding this comment.
Put generic Kconfig options like this in Zephyr proper, and just select them here.
| def_bool y | ||
| select TOOLCHAIN_SUPPORTS_THREAD_LOCAL_STORAGE | ||
|
|
||
| config NEWLIB_SUPPORTED |
There was a problem hiding this comment.
I don't think a generic option should be in here. For example how will the arm-gnu-embedded toolchain enable NEWLIB_SUPPORTED. This should be in Zephyr proper and have something like:
config TOOLCHAIN_ZEPHYR_SUPPORTS_NEWLIB`
def_bool y
select NEWLIB_SUPPORTED
There was a problem hiding this comment.
or add select NEWLIB_SUPPORTED under config TOOLCHAIN_ZEPHYR_0_16
There was a problem hiding this comment.
I've already got a proposed patch which does that (no need for the version check, Zephyr SDK has always supported newlib). I was just following the suggestion about where similar mechanism for Picolibc should live, and that will live in sdk-ng. Happy to have it in Zephyr instead; it's a lot easier to manage there anyways.
|
Closing as stale. Please re-open if this is still relevant. |
This lets Kconfig stanzas detect newlib support in the toolchain
Working on zephyr PR zephyrproject-rtos/zephyr#54637
Signed-off-by: Keith Packard [email protected]